No get-activity-params spec

yetanalytics / lrs

Protocols, specifications, and logic for building an xAPI Learning Record Store (LRS) in Clojure(Script).

https://www.yetanalytics.com/lrs

Apache License 2.0

4 stars 1 forks source link

No get-activity-params spec #24

Open kelvinqian00 opened 3 years ago

kelvinqian00 commented 3 years ago

In lrs.protocol, there is no ::get-activity-params spec, even though there are ::get-statements-params and ::get-person-params specs for statement and agent queries, respectively.

milt commented 1 year ago

This appears to have been added by you: https://github.com/yetanalytics/lrs/commit/6515ee0756ea57276808b8a841eea206bfca90a3

We good to close?

kelvinqian00 commented 1 year ago

Huh that must've been before I mentioned issues on their respective PRs, and/or vice versa. So I guess you can go ahead.