LRS-34 remove padding and margins, use align-items baseline with grid

yetanalytics / lrs

Protocols, specifications, and logic for building an xAPI Learning Record Store (LRS) in Clojure(Script).

https://www.yetanalytics.com/lrs

Apache License 2.0

4 stars 1 forks source link

LRS-34 remove padding and margins, use align-items baseline with grid #42

Closed milt closed 3 years ago

milt commented 3 years ago

We were fighting the grid styling with padding, margin, etc. This is much improved if we use the align-items: baseline property and let grid control the layout.

before:

after:

kelvinqian00 commented 3 years ago

The previous version actually looks better than the new version, if that screenshot is anything to go by. But if the change makes development much easier, it would be a worthwhile tradeoff.

milt commented 3 years ago

Yeah the trick is, the old version was only aligned by a bunch of matching paddings, and was really brittle, since it wasn't actually using the grid to align. This should be much more tolerant of the data you display as a result, but the tradeoff is stuff like being to apply full borders + background colors w/o additional css fiddling which I don't have the inclination to do. I'd rather keep it minimal for now, with a more sound layout.