Spec failure on `format-statement-ids`

yetanalytics / lrs

Protocols, specifications, and logic for building an xAPI Learning Record Store (LRS) in Clojure(Script).

https://www.yetanalytics.com/lrs

Apache License 2.0

4 stars 1 forks source link

Spec failure on `format-statement-ids` #52

Closed kelvinqian00 closed 3 years ago

kelvinqian00 commented 3 years ago

If instrumentation is turned on, format-statement-ids can throw a spec failure. The reason for this is that if the Statement being formatted has a SubStatement, that SubStatement is recursively passed in; since SubStatements do not have IDs, they fail the ::xs/lrs-statement spec.

milt commented 3 years ago

ns please!

kelvinqian00 commented 3 years ago

From com.yetanalytics.lrs.xapi.statements. (Apologies, I thought the fn name made it self-evident.)

kelvinqian00 commented 3 years ago

Addressed in #54