Closed milt closed 2 years ago
I would strongly advise adding a test for this fix, though I'm not going to block on it since 1) the doall
fix is really small and obvious and 2) being buried deep in interceptor code, I'm not sure how easy it would be to test this.
I don't feel a test is really needed here: If you look at the docs and issues on Cheshire you'll find that it intentionally lazily parses top-level arrays (which we have in this case) unless you use parse-stream-strict
, which has some other connotations so I don't want to swap out the function used.
As you point out a test would also be pretty difficult here, and would approach testing a dep which one should not do.
LRS-57 Given the following multipart request containing lots of statements:
lrs
fails to parse the JSON and throws:This PR addresses the issue (which only occurs on the clj lrs) by wrapping the JSON parsing for attachments in a
doall