Signed Statement Comparison is incorrect - Githubissues

yetanalytics / lrs

Protocols, specifications, and logic for building an xAPI Learning Record Store (LRS) in Clojure(Script).

https://www.yetanalytics.com/lrs

Apache License 2.0

4 stars 1 forks source link

Signed Statement Comparison is incorrect #64

Closed milt closed 2 years ago

milt commented 2 years ago

When we validate a signed statement, we do not use the spec's comparison exceptions: https://github.com/yetanalytics/lrs/blob/master/src/main/com/yetanalytics/lrs/pedestal/interceptor/xapi/statements/attachment.cljc#L152-L153

We should do this per the method in: https://github.com/yetanalytics/lrs/pull/57