yetanalytics / lrs

Protocols, specifications, and logic for building an xAPI Learning Record Store (LRS) in Clojure(Script).
https://www.yetanalytics.com/lrs
Apache License 2.0
4 stars 1 forks source link

Correct Signed Statement Comparison #65

Closed milt closed 2 years ago

milt commented 2 years ago

Corrects the issue mentioned in #64

Use improved statement equality check for signed statement comparison.

While doing this I noticed that lrs takes the extra step of removing the attachments key, which isn't mentioned in the comparison instructions but appears to be necessary to run the conformance tests, which omit attachments.

See a workflow run proving this here: https://github.com/yetanalytics/lrs/actions/runs/1365198557

Relevant spec on signed statements: https://github.com/adlnet/xAPI-Spec/blob/master/xAPI-Data.md#26-signed-statements