yetanalytics / lrs

Protocols, specifications, and logic for building an xAPI Learning Record Store (LRS) in Clojure(Script).
https://www.yetanalytics.com/lrs
Apache License 2.0
4 stars 1 forks source link

LRS-75 Make multipart parsing more strict #83

Closed milt closed 2 years ago

milt commented 2 years ago

LRS-74 Apparently our clj multipart parsing allows either a crlf or just an lf. That seems wrong! Cljs is more discerning. Actually it shared some of the same issues with boundary checking, and this is addressed now.

This PR:

kelvinqian00 commented 2 years ago

(As you might've seen, we should get a linter workflow for lrs at some point.)

milt commented 2 years ago

(As you might've seen, we should get a linter workflow for lrs at some point.)

Yep, I'll put in a ticket. I have local kondo and will just do that for now on this PR