yetanalytics / lrsql

A SQL-based Learning Record Store
https://www.sqllrs.com
Apache License 2.0
91 stars 17 forks source link

delete-actor #325

Closed invaliduser closed 1 year ago

invaliduser commented 1 year ago

additions to sqlite/record.clj, appropriate additions to delete.sql and query.sql, addition to backend/protocol.clj

kelvinqian00 commented 1 year ago

Remember that SQLite is only half of the SQL LRS backend; there's also the Postgres version that will need to be implemented.

kelvinqian00 commented 1 year ago

I also noticed that you did not use any instances of ON DELETE CASCADE. Which is fair, since that would require changes to the DDL which will require SQL migrations, and those are always inherently risky (at least moreso than just adding cascades manually like you have here). But then again, ON DELETE CASCADE would make the delete command itself cleaner.

cliffcaseyyet commented 1 year ago

Remember that SQLite is only half of the SQL LRS backend; there's also the Postgres version that will need to be implemented.

let him get a working SQLite first, then go back. TBH this is almost all ANSI and one-liners so that port is going to be 30 minutes once all is said and done.