search

yetanalytics / lrsql

A SQL-based Learning Record Store
https://www.sqllrs.com
Apache License 2.0
91 stars 17 forks source link

Added no-opener to hrefs to restrict access in opened windows against… #346

Closed ADLMeganBohland closed 12 months ago

ADLMeganBohland commented 1 year ago

… possible attacks

cliffcaseyyet commented 12 months ago

@ADLMeganBohland

I am concerned this may not be addressing what you are expecting it to. This is the template for documentation we host, i.e. this page. It has a similar footer to the actual application, so I am assuming that was what you wanted to modify? In that case its in clojurescript in the lrs-admin-ui project. The way it works is that is built separately and this simply imports and serves it as UI. If that is the case you may be looking for this file.

ADLMeganBohland commented 12 months ago

Whoops! Thank you Cliff. I’m new to Clojure and completely misread that. Thank you!

Megan Bohland Software Developer III Seta Contractor Advanced Distributed Learning (ADL) Initiative Web: adlnet.gov Cell: 864-337-2039 @.***

From: Cliff Casey @.> Sent: Tuesday, November 14, 2023 1:05 PM To: yetanalytics/lrsql @.> Cc: Megan Bohland @.>; Mention @.> Subject: Re: [yetanalytics/lrsql] Added no-opener to hrefs to restrict access in opened windows against… (PR #346)

@ADLMeganBohlandhttps://github.com/ADLMeganBohland

I am concerned this may not be addressing what you are expecting it to. This is the template for documentation we host, i.e. this pagehttps://yetanalytics.github.io/lrsql/. It has a similar footer to the actual application, so I am assuming that was what you wanted to modify? In that case its in clojurescript in the lrs-admin-ui projecthttps://github.com/yetanalytics/lrs-admin-ui. The way it works is that is built separately and this simply imports and serves it as UI.

— Reply to this email directly, view it on GitHubhttps://github.com/yetanalytics/lrsql/pull/346#issuecomment-1810845431, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXZSOZF4ELKZAMJ37PBAIYTYEOXDPAVCNFSM6AAAAAA7EY3ACKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJQHA2DKNBTGE. You are receiving this because you were mentioned.Message ID: @.***>

ADLMeganBohland commented 12 months ago

I have created the changes in the other correct repo. I am closing this out as it was incorrect.