search

yetanalytics / lrsql

A SQL-based Learning Record Store
https://www.sqllrs.com
Apache License 2.0
91 stars 17 forks source link

[SQL-250] UI no longer cares about HTML #414

Closed cliffcaseyyet closed 4 months ago

cliffcaseyyet commented 4 months ago

TODO: bump UI version after release.

kelvinqian00 commented 4 months ago

SQLite CI is failing...

kelvinqian00 commented 4 months ago

In addition, we'll need to update the env var docs to say that LRSQL_ENABLE_STMT_HTML will no longer affect the statement browser in UI. Right now this is the description (emphasis mine):

Whether or not HTML data is returned in the LRS HTTP response. If false disables HTML rendering even if LRSQL_ENABLE_ADMIN_UI is true. In that case the UI will not display the Statement Browser feature.

cliffcaseyyet commented 4 months ago

Oh dear I missed a spot:

https://github.com/yetanalytics/lrsql/blob/d967da8456be2df6fcf3243ea15ea1f706338e62/doc/endpoints.md?plain=1#L44

https://github.com/yetanalytics/lrsql/pull/414/commits/2f4198cf77871f6cdd1091f2ee54fd4b9999d49d