search

yetibot / core

:expressionless: Core yetibot utilities, extracted for shared use among Yetibot and its various plugins
https://yetibot.com
Eclipse Public License 1.0
27 stars 17 forks source link

Extirpate lein npm #110

Closed devth closed 4 years ago

devth commented 4 years ago

Using lein-npm to dynamically pull yetibot-dashboard has been unreliable and causing intermittent build failures. And it's really not necessary. This PR removes lein-npm and includes a simple bash script to pull latest yetibot-dashboard and bake the built html/js/css into the git repo under resources/public (essentially vendoring it). No more intermittent build failures! And now we don't rely on npm being up on every single build.

codecov[bot] commented 4 years ago

Codecov Report

Merging #110 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #110   +/-   ##
=======================================
  Coverage   43.76%   43.76%           
=======================================
  Files          90       90           
  Lines        3578     3578           
  Branches      166      166           
=======================================
  Hits         1566     1566           
  Misses       1846     1846           
  Partials      166      166
Impacted Files Coverage Δ
src/yetibot/core/webapp/views/common.clj 11.11% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ddf773a...c661c3d. Read the comment docs.