yetibot / core

:expressionless: Core yetibot utilities, extracted for shared use among Yetibot and its various plugins
https://yetibot.com
Eclipse Public License 1.0
27 stars 17 forks source link

mods to core/config.clj and added test for it #163

Closed gkspranger closed 3 years ago

gkspranger commented 3 years ago

not sure how you are going to feel about me modifying the arity of those functions .. it won't hurt my feelings if you want to reject, i am just trying to find a "pure" way i can test these functions that don't rely on environmental factors ..

codecov[bot] commented 3 years ago

Codecov Report

Merging #163 (c24ebd4) into master (9f6f7b6) will increase coverage by 0.33%. The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   46.44%   46.77%   +0.33%     
==========================================
  Files          94       94              
  Lines        4119     4126       +7     
  Branches      197      197              
==========================================
+ Hits         1913     1930      +17     
+ Misses       2009     1999      -10     
  Partials      197      197              
Impacted Files Coverage Δ
src/yetibot/core/config.clj 78.12% <73.33%> (+43.50%) :arrow_up:
src/yetibot/core/util/config.clj 56.25% <100.00%> (+1.41%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9f6f7b6...c24ebd4. Read the comment docs.