Closed gkspranger closed 3 years ago
Merging #163 (c24ebd4) into master (9f6f7b6) will increase coverage by
0.33%
. The diff coverage is75.00%
.
@@ Coverage Diff @@
## master #163 +/- ##
==========================================
+ Coverage 46.44% 46.77% +0.33%
==========================================
Files 94 94
Lines 4119 4126 +7
Branches 197 197
==========================================
+ Hits 1913 1930 +17
+ Misses 2009 1999 -10
Partials 197 197
Impacted Files | Coverage Δ | |
---|---|---|
src/yetibot/core/config.clj | 78.12% <73.33%> (+43.50%) |
:arrow_up: |
src/yetibot/core/util/config.clj | 56.25% <100.00%> (+1.41%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9f6f7b6...c24ebd4. Read the comment docs.
if-not
prefixed-env-vars
to allow for user defined env vars, mainly for testing .. arity/0 (original func signature) passes inenviron.core/env
to arity/1config-from-env-or-file
to allow for user defined file cfgs and env cfgs .. arity/0 (original func signature) passes inload-edn!
andprefixed-env-vars
to arity/2 -- which were previously in the body of the function(comment)
not sure how you are going to feel about me modifying the arity of those functions .. it won't hurt my feelings if you want to reject, i am just trying to find a "pure" way i can test these functions that don't rely on environmental factors ..