yetibot / core

:expressionless: Core yetibot utilities, extracted for shared use among Yetibot and its various plugins
https://yetibot.com
Eclipse Public License 1.0
27 stars 17 forks source link

extract generation of SQL query string from query map to allow for testing of generated statements #165

Closed gkspranger closed 3 years ago

gkspranger commented 3 years ago

i hope i am not being petty here .. i just like to be able to see/test the generated SQL before i actually use it .. i also get the generation of the SQL string is pretty simple, but there is real logic/transformation there that might be good to test

i decided to destructure in the (let) vs the function args so my editor is happy when viewing function docs

codecov[bot] commented 3 years ago

Codecov Report

Merging #165 (d356b69) into master (e890630) will increase coverage by 0.09%. The diff coverage is 82.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
+ Coverage   46.82%   46.92%   +0.09%     
==========================================
  Files          94       94              
  Lines        4130     4134       +4     
  Branches      197      195       -2     
==========================================
+ Hits         1934     1940       +6     
  Misses       1999     1999              
+ Partials      197      195       -2     
Impacted Files Coverage Δ
src/yetibot/core/db/util.clj 72.88% <82.60%> (+2.70%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e890630...d356b69. Read the comment docs.