Codecov Report

Merging #168 (ac2dd3d) into master (e35cc77) will increase coverage by 2.53%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage   47.03%   49.56%   +2.53%     
==========================================
  Files          94       94              
  Lines        4142     4142              
  Branches      195      198       +3     
==========================================
+ Hits         1948     2053     +105     
+ Misses       1999     1891     -108     
- Partials      195      198       +3

Impacted Files	Coverage Δ
src/yetibot/core/repl.clj	`18.18% <0.00%> (-36.37%)`	:arrow_down:
src/yetibot/core/commands/observe.clj	`15.70% <0.00%> (+1.65%)`	:arrow_up:
src/yetibot/core/commands/render.clj	`100.00% <0.00%> (+3.22%)`	:arrow_up:
src/yetibot/core/commands/category.clj	`33.33% <0.00%> (+4.44%)`	:arrow_up:
src/yetibot/core/models/default_command.clj	`57.14% <0.00%> (+7.14%)`	:arrow_up:
src/yetibot/core/commands/collections.clj	`74.92% <0.00%> (+34.74%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e35cc77...ac2dd3d. Read the comment docs.

gkspranger commented 3 years ago

found root cause of race condition in handler tests .. commands were not "loaded" when adding a new test NS, and so checks in handler failed due to ::

org.postgresql.util.PSQLException: ERROR: relation "yetibot_channel" does not exist
  Position: 15
  org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2497)
  org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2233)

solution is to call (load-commands) in parent (facts) -- tried (load-minimal), but did not work 🤷 closing and will add to next PR

yetibot / core

please don't merge me #168

Codecov Report