Closed gkspranger closed 3 years ago
Merging #171 (2df6dc5) into master (2e57e69) will increase coverage by
0.15%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #171 +/- ##
==========================================
+ Coverage 49.54% 49.69% +0.15%
==========================================
Files 94 94
Lines 4142 4141 -1
Branches 197 197
==========================================
+ Hits 2052 2058 +6
+ Misses 1893 1886 -7
Partials 197 197
Impacted Files | Coverage Δ | |
---|---|---|
src/yetibot/core/models/default_command.clj | 100.00% <100.00%> (+50.00%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2e57e69...2df6dc5. Read the comment docs.
(configured-default-command)
-- using(get)
vs(or)
, 98% sure it did not change behavior(not (=))
with(not=)
a note about
(fallback-enabled?)
.. i didn't want to change the behavior of the function -- but it feels a bit "off", but nothing that has to be immediately changed .. let me explain ::(= "false" "false") => true
(= "false" false) => false
<< that said, it would never make it that far because(blank? false) => true
true
is passed into function, it blows up because(blank? true)
throws runtime exception(= "false" "true") => false
all that said -- this PR is OK for what it is supposed to do -- add tests and small refactor wins where possible ..
THANKS FOR THE HELP WITH MOCKS 🥳