migrate to midje for core.commands.alias

[gkspranger]

• src/yetibot/core/commands/alias.clj
  • small kondo cleanup changes by dropping refs and unused "vars"
  • made more idiomatic by using (run!) vs (dorun (map))
• test/yetibot/core/test/commands/alias.clj
  • migrated to midje
  • added new tests << including some privates

not curing cancer with this one -- but small move to having midje everywhere

i think codecov is going to yell at me because i made a change to src (load-aliases) without adding tests << is minor and hard to truly test because of side-effects

[codecov[bot]]

Codecov Report

Merging #182 (8427cf8) into master (008506e) will increase coverage by 0.62%. The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage   52.55%   53.18%   +0.62%     
==========================================
  Files          94       94              
  Lines        4131     4131              
  Branches      211      211              
==========================================
+ Hits         2171     2197      +26     
+ Misses       1749     1723      -26     
  Partials      211      211              

Impacted Files	Coverage Δ
src/yetibot/core/commands/alias.clj	56.16% <50.00%> (+35.61%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 008506e...8427cf8. Read the comment docs.