migrate tests to midje, organize tests to be with similar tests, kondo clean some src files

[gkspranger]

• src/yetibot/core/commands/collections.clj
  • kondo clean unused refs and bindings
  • codeclimate change to use recommended (not-empty) vs (not (empty?))
• test/yetibot/core/test/commands/collections.clj
  • kondo clean unused refs and bindings
• test/yetibot/core/test/commands/collections.clj
  • migrate tests to midje
  • kondo clean unused refs and bindings
  • add tests for untested collections functions
• test/yetibot/core/test/util/command_info.clj
  • migrate tests to midje
  • kondo clean unused refs and bindings
  • moved collections related tests to the collecitons test file
  • removed redundant collections tests

sorry about the size of this one .. the 2 test files were somewhat intertwined, and the collections tests were already large to begin with ..

[gkspranger]

so 1st set of failures i was sort of able to reproduce by docker-compose down && rm -fr target/ postgres-data/ -- then proceed with normal local testing methods .. 2nd set of failures i wasn't able to reproduce locally at all -- but again, it looked like the previous "commands not loaded for testing" fails that we have seen before -- so i once again called the (load-commands) function for the interpreter tests to see if that helped ..

it feels like the order in which tests are run locally is different than what we see in GH actions -- which may be the cause of the race condition of commands not already being loaded to test ..

hope this makes sense

[codecov[bot]]

Codecov Report

Merging #185 (e28ee96) into master (254da5c) will increase coverage by 0.44%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   53.18%   53.63%   +0.44%     
==========================================
  Files          94       94              
  Lines        4131     4130       -1     
  Branches      211      212       +1     
==========================================
+ Hits         2197     2215      +18     
+ Misses       1723     1703      -20     
- Partials      211      212       +1     

Impacted Files	Coverage Δ
src/yetibot/core/commands/collections.clj	80.90% <100.00%> (+5.98%)	:arrow_up:
src/yetibot/core/util/command_info.clj	90.32% <100.00%> (ø)
src/yetibot/core/commands/help.clj	21.05% <0.00%> (-2.64%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 254da5c...e28ee96. Read the comment docs.