migrate to midje for core.commands.observe and some kondo/codeclimate cleaning

[gkspranger]

• src/yetibot/core/commands/observe.clj

  • did some kondo cleaning
  • made changes to (if-let) to (when-let) because codeclimate said it is more idio than returning nil for logical false
  • made changes to (dorun (map)) to (run!) because codeclimate said it is more idio

• test/yetibot/core/test/commands/observe.clj

  • migrated tests to midje and added one, non-amazing test

[codecov[bot]]

Codecov Report

Merging #191 (9f54375) into master (40e04ea) will increase coverage by 0.16%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
+ Coverage   54.14%   54.30%   +0.16%     
==========================================
  Files          94       94              
  Lines        4130     4130              
  Branches      209      209              
==========================================
+ Hits         2236     2243       +7     
+ Misses       1685     1678       -7     
  Partials      209      209              

Impacted Files	Coverage Δ
src/yetibot/core/commands/observe.clj	22.31% <0.00%> (+6.61%)	:arrow_up:
src/yetibot/core/commands/help.clj	21.05% <0.00%> (-2.64%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 40e04ea...9f54375. Read the comment docs.