small refactor of core.adapters.slack/send-msg

[gkspranger]

• src/yetibot/core/adapters/slack.clj
  • no change in behavior, function still returns nil since logging is the last action
  • extracted the send-msg options merge into own function
  • ->send-msg-options naming comes from "elements of clojure" recommendation on how to name transforms
  • extracted logging of send-msg into own function
  • it appears both log actions are not dependent on ordering, so put into one
  • motivation comes from LINK
  • send-msg becomes "workflow", while "core" is the creation of message options
• test/yetibot/core/test/adapters/slack.clj
  • you will see more meaningful tests for send-msg
  • new functions have their own tests

as always, very open to feedback, and feel free to reject .. just trying out some things i have been reading recently

take your time on this one and see if you like, because there any many opportunities like this throughout the code base

[codecov[bot]]

Codecov Report

Merging #195 (44e7743) into master (ee45e06) will increase coverage by 0.12%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage   56.74%   56.86%   +0.12%     
==========================================
  Files          94       94              
  Lines        4131     4138       +7     
  Branches      222      222              
==========================================
+ Hits         2344     2353       +9     
+ Misses       1565     1563       -2     
  Partials      222      222              

Impacted Files	Coverage Δ
src/yetibot/core/adapters/slack.clj	53.69% <83.33%> (+1.51%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ee45e06...44e7743. Read the comment docs.