refactor of adding bot response to history table

[gkspranger]

• src/yetibot/core/handler.clj
  • extracted into (->handled-expr-info) logic transforming handled expr result into useful info map to be used by other functions
  • extracted into (add-bot-response-to-history) logic recording bot response to history table when option is enabled
  • extracted into (->handled-expr-results) logic transforming handled expr results into useful collection to be returned by function
  • modified (record-and-run-raw) to use new functions and kondo-cleaned where recommended
  • extracted into (dispatch-command-response) logic dispatching response to be formatted, and ultimately passed long to send-message
  • modified (handle-raw) to use new functions
• test/yetibot/core/test/handler.clj
  • created tests for newly extracted functions

verified at DB level history is being added as expected when issuing bot commands (see below)

yetibot=# \pset format csv
Output format is csv.

yetibot=# SELECT body, correlation_id FROM yetibot_history;
body,correlation_id
!echo hello,1625686226960--1704927648
hello,1625686226960--1704927648

!echo hello | echo world,1625686238105--752889806
world hello,1625686238105--752889806

!history,1625686317249-1915014611
"greg in greg at 12:30 PM 07/07: !echo hello
myeti in greg at 12:30 PM 07/07: hello
greg in greg at 12:30 PM 07/07: !echo hello | echo world
myeti in greg at 12:30 PM 07/07: world hello",1625686317249-1915014611

[codecov[bot]]

Codecov Report

Merging #198 (44b26b5) into master (7a7949d) will increase coverage by 0.63%. The diff coverage is 48.38%.

@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
+ Coverage   57.53%   58.17%   +0.63%     
==========================================
  Files          94       94              
  Lines        4145     4158      +13     
  Branches      222      224       +2     
==========================================
+ Hits         2385     2419      +34     
+ Misses       1538     1515      -23     
- Partials      222      224       +2     

Impacted Files	Coverage Δ
src/yetibot/core/handler.clj	60.16% <48.38%> (+23.79%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7a7949d...44b26b5. Read the comment docs.