yetibot / core

:expressionless: Core yetibot utilities, extracted for shared use among Yetibot and its various plugins
https://yetibot.com
Eclipse Public License 1.0
27 stars 17 forks source link

Rename room command to channel #58

Closed kaffein closed 5 years ago

kaffein commented 5 years ago

hey guys,

here is the PR related to https://github.com/yetibot/yetibot/issues/799 : Renaming the room command to channel :-)

So what do we have here :

I have said almost everywhere in the previous sentence because of course we can not change everything containing the word room within it and especially the underlying data model related to rooms.

Therefore, a little hint for the review ^^ :

[{:keys [adapter room] :as chat-source} ts]

otherwise, we can get into trouble and you should let me know if you find such changes so I can fix it ;-)

Now, here is how it renders so far :

New channel command in action

channel_cmd_in_action

The room command (maintained for compatibility)

room_cmd_compatibility

feel free to play around with this branch guys and as usual, do not hesitate to let me know if you find any issue related to the changes introduced.

thanks \o

devth commented 5 years ago

💯 looks great @kaffein. I tested and everything looks good so I'll merge, then test a little more before release. Thanks!!!!

kaffein commented 5 years ago

thanks @devth ;-)