Closed kaffein closed 4 years ago
@kaffein that was fast π
What do you think about shadow-cljs? Should we consider it? I've never used it but heard a lot of good things.
Actually we use shadow-cljs
here πso I'd say it is pretty convenient and easy to configure, with very good documentation. And Thomas Heller is very active and helps a lot on Clojurian. So yeah I'd say I'm definitely up for it π€π
Quick question @devth : what do you think about the dependency management ? should we have a pure shadow-cljs
-managed build and totally strip out leiningen or do you want to continue having the latter ?
Not sure as I havenβt used shadow. Does it integrate nicely with lein? Instinct would be to keep using lein so we have consistent builds across all Yetibot repos.
Integration with lein
is pretty good so we can go this way then π. I will restore the project.clj
Sounds good! Feel free to suggest otherwise as I'm not the one doing the work, and it's been awhile since I've done any cljs π
We're good ππ
@kaffein I'll let you merge and create new PRs as you see fit. I'll just review / provide feedback or ideas along the way.
Wow cool π thanks for your trust π!!! I'll do my best π and thanks for your feedbacks
by the way @devth, do I need to have some rights/roles set in order to be able to merge ? I do not seem to have the merge button available at the moment :)
Sorry about that @kaffein π Should be good to go now - see https://github.com/orgs/yetibot/teams/frontend/discussions
That's cool ππ thanks a lot π
"It's alive" https://media.giphy.com/media/d3Kq5w84bzlBLVDO/source.gif -- Dr Frankenstein
can you PTAL @devth :)
thanks