yetibot / dashboard

The new (as of 2020) CLJS frontend dashboard for Yetibot
4 stars 1 forks source link

Project bootstrap #2

Closed kaffein closed 4 years ago

kaffein commented 4 years ago

"It's alive" https://media.giphy.com/media/d3Kq5w84bzlBLVDO/source.gif -- Dr Frankenstein

can you PTAL @devth :)

thanks

devth commented 4 years ago

@kaffein that was fast 😁

What do you think about shadow-cljs? Should we consider it? I've never used it but heard a lot of good things.

kaffein commented 4 years ago

Actually we use shadow-cljs here πŸ˜„so I'd say it is pretty convenient and easy to configure, with very good documentation. And Thomas Heller is very active and helps a lot on Clojurian. So yeah I'd say I'm definitely up for it πŸ€—πŸ‘

kaffein commented 4 years ago

Quick question @devth : what do you think about the dependency management ? should we have a pure shadow-cljs-managed build and totally strip out leiningen or do you want to continue having the latter ?

devth commented 4 years ago

Not sure as I haven’t used shadow. Does it integrate nicely with lein? Instinct would be to keep using lein so we have consistent builds across all Yetibot repos.

kaffein commented 4 years ago

Integration with lein is pretty good so we can go this way then πŸ‘. I will restore the project.clj

devth commented 4 years ago

Sounds good! Feel free to suggest otherwise as I'm not the one doing the work, and it's been awhile since I've done any cljs πŸ˜„

kaffein commented 4 years ago

We're good πŸ˜ŠπŸ‘

devth commented 4 years ago

@kaffein I'll let you merge and create new PRs as you see fit. I'll just review / provide feedback or ideas along the way.

kaffein commented 4 years ago

Wow cool πŸ™ thanks for your trust πŸ˜‰!!! I'll do my best 😊 and thanks for your feedbacks

kaffein commented 4 years ago

by the way @devth, do I need to have some rights/roles set in order to be able to merge ? I do not seem to have the merge button available at the moment :)

devth commented 4 years ago

Sorry about that @kaffein πŸ˜… Should be good to go now - see https://github.com/orgs/yetibot/teams/frontend/discussions

kaffein commented 4 years ago

That's cool πŸ‘πŸ˜„ thanks a lot πŸ˜‰