search

yeun / open-color

Color scheme for UI design.
https://yeun.github.io/open-color/
MIT License
5.27k stars 239 forks source link

Upgrade lodash #93

Closed yeun closed 5 years ago

foray1010 commented 5 years ago

@yeun what is the reason to include npm and lodash here? I did a quick search in this repo, can't find we are using these dependencies https://github.com/yeun/open-color/search?q=npm&unscoped_q=npm https://github.com/yeun/open-color/search?q=lodash&unscoped_q=lodash

the problem of adding them to dependencies is it downloads a LOT of unnecessary dependencies when I develop my app (added ~1400 lines in my yarn.lock) https://github.com/foray1010/Popup-my-Bookmarks/pull/497/files

yeun commented 5 years ago

@sairion Could you check this out?

sairion commented 5 years ago

not sure why both deps are added, they are not needed.

sairion commented 5 years ago

@foray1010 I removed the dependencies section and until new pkg is pushed, you can rely on older version (which is 1.6.3) if you can manually specify one. Sorry for inconvenience

sairion commented 5 years ago

@yeun please tag 1.7.1 via npm version patch and publish new pkg