search

yevgenko / cookbook-php-fpm

Installs/Configures php-fpm
http://community.opscode.com/cookbooks/php-fpm
Apache License 2.0
68 stars 117 forks source link

Don't always disable the default 'www' pool #62

Closed jbillo closed 9 years ago

jbillo commented 9 years ago

If using the default 'www' pool, this recipe always disables and re-enables it on every chef-client run. Don't run the php_fpm_pool disable statement if the pool explicitly exists in the node['php-fpm']['pools'] attribute.

yevgenko commented 9 years ago

Dear @jbillo,

thank you for PR, please see my comments ;)

Yours sincerely

Yevhen

jbillo commented 9 years ago

Thanks! I like the cleaner style. I'll add another commit to the PR if that's OK then?

yevgenko commented 9 years ago

sure :)

dwradcliffe commented 9 years ago

any update here? I'd love to see this fix released! :)

jbillo commented 9 years ago

Sorry, this fell off my radar. I've made the requested syntax update so this PR can be reviewed again and considered for merge.

brugidou commented 9 years ago

+1

zlorfi commented 9 years ago

+1

spajus commented 9 years ago

:+1: