move defaults out of template

yevgenko / cookbook-php-fpm

Installs/Configures php-fpm

http://community.opscode.com/cookbooks/php-fpm

Apache License 2.0

68 stars 117 forks source link

move defaults out of template #89

Closed glensc closed 7 years ago

glensc commented 8 years ago

define them as cookbook attributes

benefits:

business logic is out of template
attribute defaults can be overriden per role/environment

replaces: #30

glensc commented 8 years ago

please merge, i have bunch of other changes planned on top of this commit

legal90 commented 8 years ago

+1 on this. It is really inexplicit to get default values rendered from the template logic. In Chef it's a common practice to use attribute files for that.

glensc commented 8 years ago

@yevgenko this cookbook is probably dead? i've trying to push this in since Dec 12, 2013 (#30)

yevgenko commented 7 years ago

Hey @glensc, sorry for late response and for ignoring project for awhile, I'll try to catch up with this.