Closed cecton closed 10 months ago
cc @kirillsemyonkin
Seems like its generating an unexpected comma somewhere (be it struct or fn) when there are no props but there are generic types
Repro:
#[autoprops]
#[function_component]
pub fn Test<T>() -> Html {
html! {}
}
@kirillsemyonkin fixed
I think to trigger CI you may wanted to rerun all jobs, sometimes I see that button in the actions section
No I really wanted to trigger the CI with a different commit hash ^_^
TIL that you need to add the rust version in swatinem/cache key for it to work properly :woman_facepalming: I have like 10 repos that are not doing that huh
Here is another one
Fixed
-> Html
on the fn, nor HtmlResult
works (seems like that is replaced by Html
) - following does not work:#[autoprops]
#[function_component]
pub fn Test() -> HtmlResult {
Ok(html! {})
}
@kirillsemyonkin fixed
@hamza1311 @kirillsemyonkin ok I think this is ready now
What is the current status of this?
@yewstack/yew can I have a final review on this?
@cecton hi you are my angel, thanks for the work
@yewstack/yew can I have a final review on this?
Can we skip such a review since it is more-or-less separate from Yew and proceed to merge? We can have extra merges later, independent of Yew's slow cycle
Ideally anyone's work on a stylist PR for #[styled_component]
-> #[styled]
(for #[styled] #[autoprops] #[component]
progress) should happen somewhere around now as well
Can we skip such a review since it is more-or-less separate from Yew and proceed to merge? We can have extra merges later, independent of Yew's slow cycle
Yeah I think the other maintainers are a bit overbooked at the moment so let's merge it as is. Worst case scenario we open issues or fix things later on.
Fixes #8 Fixes #7 Fixes #9 Fixes #3 Related to https://github.com/yewstack/yew/pull/3505