yewzijian / 3DFeatNet

3DFeat-Net: Weakly Supervised Local 3D Features for Point Cloud Registration
MIT License
220 stars 46 forks source link

Data preprocessing scripts issue #10

Closed Milos9304 closed 5 years ago

Milos9304 commented 5 years ago

Hi, I am following your guide to preprocess Oxford dataset for training and I am running into several issues, are you sure the GitHub version is the tested one?

The issues include:

yewzijian commented 5 years ago

Yes, the github version is what I used to generate the dataset.

Milos9304 commented 5 years ago

The issue is present when processing these datasets: -2014-11-18-13-20-12 -2015-02-10-11-58-05 -2015-02-24-12-32-19 -2015-03-24-13-47-33 -2015-05-22-11-14-30 -2015-07-08-13-37-17

I found out it is enough to increase parameter in compute_subsequent_offsets(ins_positions, 5000);` from 5000 to 8000 (except 2015-02-10-11-58-05 where 15000 is required). Hope this doesn't affect quality of the output.

I also added the following lines before if distances(startIdx, endIdx-startIdx-1) > ACCUMULATE_DISTANCE - 5:

if startIdx > numFrames || endIdx > numFrames warning(sprintf('Skipping %i - %i frames due to out of array bounds.', startIdx, endIdx)) break end This skips a few frames, but ensures the script doesn't crash. This warning is present at every single traversal that is being processed.

yewzijian commented 5 years ago

Hi @Milos9304 , I just tested the code on Matlab R2019a, but I still didn't get those errors. Weird. The 5000 is there mainly for speed (so we don't have to compare with all N other INS positions), and to avoid those parts where the car is moving very slowly such that many many frames is required to cover 60m. The warnings appear for frames where 5000 is insufficient, and can be safely ignored. That said, there shouldn't be any problems increasing this limit to 8000.

Milos9304 commented 5 years ago

@yewzijian thanks for checking that! It's really weird, but I found my ways to solve the issues. Hopefully that's a problem on my side only and others don't get the same one, so you can close this issue for now.

yewzijian commented 5 years ago

You're welcome :) Will close this issue for now.