yext / edward

A tool for managing local microservice instances
http://engblog.yext.com/edward/
MIT License
171 stars 32 forks source link

Edward stop doesn't actually check running services if it needs to use sudo #148

Closed NorbertChuYext closed 6 years ago

NorbertChuYext commented 6 years ago

Example trace

~/alpha 17:28$ edward stop Are you sure you want to stop all services? [y/n]? y One or more services use sudo. You may be prompted for your password. Password: SmsApiServer > Stop: [OK] (1.529s) ~/alpha 14:35$ edward start haproxy One or more services use sudo. You may be prompted for your password.

At time of running, the commands for SmsApiServer in edward.json, for verification that it doesn't use sudo

"name": "SmsApiServer", "path": "$ALPHA", "commands": { "build": "bazel build //src/com/yext/sms/services/api/server:SmsApiServer", "launch": "bazel-bin/src/com/yext/sms/services/api/server/SmsApiServer" },

Expected behavior would be for edward to check the list of services and not actually use sudo if it is unnecessary