search

yext / edward

A tool for managing local microservice instances
http://engblog.yext.com/edward/
MIT License
171 stars 32 forks source link

Support dotenv files #151

Open fromz opened 6 years ago

fromz commented 6 years ago

Has anyone put any thought into supporting dotenv files for environment variable management natively? I'm happy to do the dev work if we agree it's a good idea

theothertomelliott commented 6 years ago

Interesting idea! Do you have any thoughts on particular use cases for this feature? I think it could be useful, but there's potential for clashes or confusing behavior when launching services that already use dotenv internally.

fromz commented 6 years ago

Yeah, so we as a dev team heavily rely on edward for our services. Some of us have different environment variable configurations, and it would be good to be able to easily maintain that between machines without having to manage dotenv manually. I think if we made the configuration very distinct between dotenv and the existing "env" configuration, it should be fairly clear, especially if we spell out the order of precedence - e.g. shell set environment variables first, then edward "env" second, then dotenv last, or some such.

theothertomelliott commented 6 years ago

Sounds like a decent order of precedence. Would you imagine dotenv being an "always on" feature, or something you'd enable for a specific Edward config, group or service?

Are the different variable configurations on your team personal settings per developer (perhaps being manually set and listed in gitignore)?

fromz commented 6 years ago

I'd say per service initially and then maybe add it per group. What do you think? Happy to send a pr in the next few days if you agree

On Thu., 22 Feb. 2018, 11:51 am Tom Elliott, notifications@github.com wrote:

Sounds like a decent order of precedence. Would you imagine dotenv being an "always on" feature, or something you'd enable for a specific Edward config, group or service?

Are the different variable configurations on your team personal settings per developer (perhaps being manually set and listed in gitignore)?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/yext/edward/issues/151#issuecomment-367540548, or mute the thread https://github.com/notifications/unsubscribe-auth/AANiUNgI8b87DfQoSOFK-5qOHmpxp387ks5tXMgFgaJpZM4SOY7g .

theothertomelliott commented 6 years ago

Sounds good, look forward to seeing your PR! We've been adding features on the develop branch before merging for versioned releases.