Fix vector usage in target_landmark_location

yezhengSTAT / ADTnorm

ADTnorm normalizes the cell surface protein measurement of CITE-seq data, facilitating across batches and across studies data integration.

https://yezhengstat.github.io/ADTnorm/articles/ADTnorm-tutorial.html

GNU General Public License v3.0

19 stars 4 forks source link

Fix vector usage in target_landmark_location #13

Closed aathbt closed 3 months ago

aathbt commented 5 months ago

target_landmark_location length isn't checked before testing its value, which leads to an if condition being longer than 1. This causes the following error when manually setting peak location (with target_landmark_location = c(x, y))

Error in if (target_landmark_location == "fixed") { : 
  the condition has length > 1

This pull request fixes it by adding a length test beforehand.

yezhengSTAT commented 5 months ago

lol, I also noticed this issue during the last round of tests of the package, ending with exactly the same resolution. I will test the package again and push the latest version after fixing the other issues you have raised.

Thanks, Ye

aathbt commented 3 months ago

Branch closed because fix was included in bbcee3f.