yezhengSTAT / mHiC

MIT License
22 stars 10 forks source link

Mixed usage of Python2 and Python3. #8

Open aakashsur opened 5 years ago

aakashsur commented 5 years ago

It looks like s4_bin.sh uses python (which maps to python2 usually) instead of python3. I'm assuming they can all be run using python3 so I guess I would either change the python calls in the bash script or update the documentation to reflect the Python 2 usage before that step.

yezhengSTAT commented 5 years ago

All the python scripts in mHi-C are tested using python3.

aakashsur commented 5 years ago

Okay, then it looks like changing these lines should fix the problem:

https://github.com/yezhengSTAT/mHiC/blob/0d34beec4bff4f8b5cb82d8840d5080a70620022/s4_bin.sh#L166-L173

yezhengSTAT commented 5 years ago

Thanks.