yezihaohao / react-admin

:sparkles: react-admin system solution : react 后台管理系统解决方案
https://admiring-dijkstra-34cb29.netlify.com/
MIT License
6.65k stars 1.87k forks source link

一个UI的bug, 两优化,侧边栏的数据和UI分离,gitignore 增加package-lock.json #31

Closed HeavenSky closed 6 years ago

HeavenSky commented 6 years ago

第一回用pull request,有种code review的既视感,感觉有点意思 三个commit除了分离侧边栏的那个提交,其他两个改动比较简单, 下面我详细说说分离侧边栏代码改动:

// 有二级菜单 基本和一级菜单一致, 多了个sub属性,sub是个数组,数组元素和前面介绍的格式一致 { key: '/app/ui', title: 'UI', icon: 'scan', sub: [ { key: '/app/ui/buttons', title: '按钮', icon: '', }, { key: '/app/ui/icons', title: '图标', icon: '', }, { key: '/app/ui/spins', title: '加载中', icon: '', }, { key: '/app/ui/modals', title: '对话框', icon: '', }, { key: '/app/ui/notifications', title: '通知提醒框', icon: '', }, { key: '/app/ui/tabs', title: '标签页', icon: '', }, { key: '/app/ui/banners', title: '轮播图', icon: '', }, { key: '/app/ui/wysiwyg', title: '富文本', icon: '', }, { key: '/app/ui/drags', title: '拖拽', icon: '', }, { key: '/app/ui/gallery', title: '画廊', icon: '', }, ], },

HeavenSky commented 6 years ago

侧边栏UI的问题 ui

yezihaohao commented 6 years ago

谢谢PR