There is ambiguous loop in resolve_user for social auth

[iamromandev]

First Check

• [X] I added a very descriptive title to this issue.
• [X] I already read and followed all the tutorial in the docs and didn't find an answer.
• [X] I already checked if it is not related to AuthX but to Pydantic.
• [X] I already checked if it is not related to AuthX but to FastAPI.

Example Code

while True: 
     resolved_username = f"{username}{postfix}" 
     existing_username = await self._repo.get_by_username(resolved_username) 
     if not existing_username: 
         break

Description

Could you please some one check this below code base where loop is indicating something ambiguous .

https://github.com/yezz123/authx/blob/eefba52c32222b88171e4b300d025937496d7e1f/authx/services/social.py#L127-L131

Operating System

macOS

Operating System Details

No response

FastAPI Version

0.85.0

Python Version

3.9

Additional Context

No response

[iamromandev]

I believe some thing like below could solve this loop issue.

            resolved_username = username
            while True:
                postfix = str(i) if i > 0 else ""
                resolved_username = f"{username}{postfix}"
                existing_username = await self._repo.get_by_username(resolved_username)
                if not existing_username:
                    break
                i = i+1

[yezz123]

Hello, @iftenet I didn't notice that loop, but I see it can be fixed as you proposed, want to contribute and open a Pull request?

[iamromandev]

Hello, @iftenet I didn't notice that loop, but I see it can be fixed as you proposed, want to contribute and open a Pull request?

I will be glad if you give me the opportunity to contribute.

[yezz123]

Hello, @iftenet I didn't notice that loop, but I see it can be fixed as you proposed, want to contribute and open a Pull request?

I will be glad if you give me the opportunity to contribute.

Yes for sure!

I will assign it as a bug and you can work on it 🚀

[iamromandev]

@yezz123 I am going to create a PR but seems I have no permission to push.

ERROR: Permission to yezz123/authx.git denied to iftenet.

[yezz123]

@yezz123 I am going to create a PR but seems I have no permission to push.

ERROR: Permission to yezz123/authx.git denied to iftenet.

You can fork the project and try to made your changes in your fork you will find it in this way, iftenet/authx.git then a yellow head with a button create PR