search

yf0994 / guava-libraries

Automatically exported from code.google.com/p/guava-libraries
Apache License 2.0
0 stars 0 forks source link

[PATCH] Fix manifest construction for Eclipse #1160

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
This patch addresses two problems ; 

Firstly, version 2.4 of the maven-jar-plugin isn't compatible with m2eclipse ; 
see https://github.com/sonatype/m2eclipse-extras/issues/10

The patch downgrades the version to 2.3.2 as recommended in the linked issue ; 
this appears to have no adverse effect on the build.

Secondly, it places the manifest generated by the Felix maven-bundle-plugin 
into the standard META-INF folder in the root of the project. We also add this 
folder to the .gitignore list to prevent it being added to the tree.

This means that Eclipse can see the MANIFEST.MF file and correctly assess the 
OSGi metadata for the project.

This means you can now clone and import the guava project into Eclipse and use 
it to support debugging other OSGi bundles which depend upon it.

Without these changes, the POM file will have an error marker in Eclipse, and 
run configurations with the guava bundle in their plug-ins list will also have 
an error marker, listing it as "out of sync". Error markers are bad because 
they cause people to wonder what is wrong :-)

Original issue reported on code.google.com by adrian.w...@gmail.com on 5 Oct 2012 at 4:06

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by kevinb@google.com on 8 Apr 2013 at 7:02

GoogleCodeExporter commented 9 years ago 
(note the linked sonatype issue page 404s...)

Original comment by kak@google.com on 22 Aug 2013 at 10:27

GoogleCodeExporter commented 9 years ago

Original comment by kevinb@google.com on 20 Nov 2013 at 10:29

GoogleCodeExporter commented 9 years ago 
This issue has been migrated to GitHub.

It can be found at https://github.com/google/guava/issues/<id>

Original comment by cgdecker@google.com on 1 Nov 2014 at 4:13

GoogleCodeExporter commented 9 years ago

Original comment by cgdecker@google.com on 1 Nov 2014 at 4:18

GoogleCodeExporter commented 9 years ago

Original comment by cgdecker@google.com on 3 Nov 2014 at 9:08