search

yfdyh000 / PhotoSift

A fork with audio/video support, batch operations, and other optimizations.
GNU General Public License v3.0
8 stars 0 forks source link

WMP Player #2

Open Stamimail opened 3 years ago

Stamimail commented 3 years ago
  1. I wanted to use keyboard key for Play/Pause, instead of Next. For Next I'll use RightArrow keyboard key.
  2. Consider to add a new option: "Edit Start Time for Playing". It will be used to play each audio/video from the middle (like 0:20) instead of from the beginning (0:00)
yfdyh000 commented 2 years ago

Try the 1.26. https://github.com/yfdyh000/PhotoSift/releases

Stamimail commented 2 years ago

2.... "Ignore video beginnings" option (beta) I think it's work properly.

1... I think there is a problem with play/pause by spacebar, especially after click with mouse on the play button (you will see square around it = in Focus). 3... Another problem is the size of the window. It's not full. (btw, I tested only audio files) תמונה

Stamimail commented 2 years ago
  1. I do not know if it is possible but, things to be enhanced are: a. Repeat button. (Repeat one file) b. Show the Length of the file. 0:20/2:34
yfdyh000 commented 2 years ago

2.... "Ignore video beginnings" option (beta) I think it's work properly.

1... I think there is a problem with play/pause by spacebar, especially after click with mouse on the play button (you will see square around it = in Focus). 3... Another problem is the size of the window. It's not full. (btw, I tested only audio files) תמונה

Thank you for your feedback.

  1. Confirmed.
  2. Confirmed. It seems to appear only when the window is maximized.
yfdyh000 commented 2 years ago
  1. I do not know if it is possible but, things to be enhanced are: a. Repeat button. (Repeat one file) b. Show the Length of the file. 0:20/2:34

a. Should it adhere to the "Ignore video beginnings" setting? b. You can see the length in the title bar.

Stamimail commented 2 years ago

a. Repeat button has nothing to do with "Ignore video beginnings". Something like these: https://www.iphonefaq.org/files/styles/large/public/shake2.png https://www.lifewire.com/thmb/1x9zDvUX447hUzfL3IRguoV_7hk=/1359x1019/smart/filters:no_upscale()/Repeat-41cc46d037b0466c88e9a81ffa8abd3a.jpg

b. I tested mp3 files. You should remove the "0 x 0". and I think it's better to add "Length" to make it clearer (Length: 02:34). Another idea if it possible is to have the title bar dynamic : (6 / 14) - AudioFile.mp3 - 0:20/2:34 (6 / 14) - AudioFile.mp3 - 0:21/2:34 (6 / 14) - AudioFile.mp3 - 0:22/2:34

yfdyh000 commented 2 years ago

So, you need an option that enables Repeat, not a key for replay. Classifying audio files is an unexpected scenario and I haven't checked them yet.

Stamimail commented 2 years ago

So, you need an option that enables Repeat, not a key for replay.

Both of them. Play/Pause by spacebar is basic. Repeat button (or by menu) is a good enhancement.

Stamimail commented 2 years ago

Problem 3... I noticed that (for some reason) when you pressing Alt key it enlarge the WMP.

yfdyh000 commented 2 years ago

Problem 3... I noticed that (for some reason) when you pressing Alt key it enlarge the WMP.

I didn't see this... Is your menu bar changing?

Stamimail commented 2 years ago

I didn't see this... Is your menu bar changing?

No the menu bar. The WMP frame is changing. When I press the Alt key, it fixes the problem in the image above. https://user-images.githubusercontent.com/11010156/162010138-be83490c-3482-4e2f-9f71-890c47362f05.png

yfdyh000 commented 2 years ago

I didn't see this... Is your menu bar changing?

No the menu bar. The WMP frame is changing. When I press the Alt key, it fixes the problem in the image above. https://user-images.githubusercontent.com/11010156/162010138-be83490c-3482-4e2f-9f71-890c47362f05.png

Anyway, resizing the window will temporarily correct the WMP control size.

yfdyh000 commented 2 years ago

Fixed in 1.27. Fill in a new issue if it is not old.