search

yfdyh000 / tabutils

Tab Utilities's compatibility fixes release.
https://addons.mozilla.org/firefox/addon/tab-utilities-fixed/
93 stars 13 forks source link

Fix for "open new tabs next to current" #128

Open Kamui-Solo opened 7 years ago

Kamui-Solo commented 7 years ago

For example check option "open new tabs next to current" to "all", then press ctrl+shift+a to open addon manager, it will be opened outside of tab stack. This fix is for option works properly in all cases.

Kamui-Solo commented 7 years ago

Can you explain or cancel the changes for shouldStack?

It seems new tab page or addon manager page and in my case "simple mail" page, which opened from toolbar, they dosn't have referrer at all. And when we use: args.aReferrerURI || args.aRelatedToCurrent They are absolutely ignored for stacking even if checked "all" in option "open new tabs next to current" We can use: function shouldStack(tab) { let args = tab.arguments; return args.aURI != "about:blank"; } But I'm not tested it yet.

yfdyh000 commented 7 years ago

@Kamui-Solo Why the new non-relevant tab (like from toolbar, rather than the current tab) should be auto stack? If you remove the change, I'll be happy to merge it.