yfdyh000 / tabutils

Tab Utilities's compatibility fixes release.
https://addons.mozilla.org/firefox/addon/tab-utilities-fixed/
93 stars 13 forks source link

Multi-row Issue Jump #153

Open Mgldvd opened 7 years ago

Mgldvd commented 7 years ago

hi, the multi row is jumping, already disable all other plugins and try only with tabutils.

peek 2017-04-27 10-49

yfdyh000 commented 7 years ago

136

TroudhuK commented 7 years ago

I stay in 52.0.2 like a lot of users because of that...

TroudhuK commented 7 years ago

The problem seems to be because of the new tab-label-container hbox, and the CSS :

.tab-label-container {
  overflow: hidden;
}

which send overflows at each mouse movement on a tab. So the fix I found in tabutils-mt.js is:

  tabutils.addEventListener(gBrowser.mTabContainer, "overflow", function(event) {
    if (event.target.tagName == "tab") {
      event.stopPropagation();
      return;
    }
    this.enterBlockMode();
  }, false);

A problem stays with the newtab button which doesn't want to stay next to the last tab, and goes right (after hesitation lol).

TroudhuK commented 7 years ago

https://github.com/TroudhuK/tabutils/commit/ba93f983af77e18762d7af35cac3bed48628ffcf (Sorry, I didn't take time to learn how to work on github or how to make a Firefox extension) This is the code I currently use, which can certainly be improved...

TroudhuK commented 7 years ago

Just added that to fix the "new tab button(s)" behaviour:

#tabbrowser-tabs[multirow] + #new-tab-button {
  display: none;
}

#tabbrowser-tabs[multirow] .tabbrowser-arrowscrollbox > .tabs-newtab-button {
  visibility: visible;
}

Edit : It's a little buggy sometimes.