yfix / flyback

Automatically exported from code.google.com/p/flyback
0 stars 0 forks source link

Backup appears to hang after "chmod -w" #56

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Do backup with "Delete Backups when free space less than X" option
selected using a backup destination with a long path name.

What is the expected output? What do you see instead?
The last message in the GUI will be chmod -w {Backup dest}
But the BAckup button will not re-enable.
Quitting will leave the lockfile in place. Thus requiring you to manually
purge it to do the next run.

What version of the product are you using? On what operating system?
0.4

Please provide any additional information below.
I have figured out what is happening here. And I'm proud to say that I
fixed the code with zero python knowledge.

The problem is teh code does a 'df {backup dest' to figure out the free
space. For my system this results in:
df /backup
Filesystem           1K-blocks Used Available Use% Mounted on
/dev/mapper/tpad-backup
                      15604720  12672592   2145760  86% /backup

Because the LVM device has a long path, it has wrapped around causing the
code to not get the required results.

I changed line 167 of backup_backend.py from:
    stdin, stdout = os.popen4( 'df %s' % parent_backup_dir )
To:
    stdin, stdout = os.popen4( 'df -P %s' % parent_backup_dir )

The -P forces posix format eg:
df -P /backup
Filesystem         1024-blocks      Used Available Capacity Mounted on
/dev/mapper/tpad-backup  15604720  12672592   2145760      86% /backup

Which is always on one line - voila!

flyback works happily again.

Original issue reported on code.google.com by grid...@gmail.com on 24 Jun 2008 at 6:01

GoogleCodeExporter commented 8 years ago
I have made "-P" modification to the warpback branch of flyback
http://code.google.com/p/warpback

Original comment by jarrod.c...@gmail.com on 1 Dec 2008 at 2:02

GoogleCodeExporter commented 8 years ago
fixed in svn

Original comment by pub...@kered.org on 5 Dec 2008 at 7:01

GoogleCodeExporter commented 8 years ago
Issue 54 has been merged into this issue.

Original comment by pub...@kered.org on 5 Dec 2008 at 7:02