search

yggdrasil-network / yggdrasil-android

Reference implementation for connecting to the Yggdrasil Network from Android devices
MIT License
106 stars 18 forks source link

F-Droid can't build #58

Open licaon-kter opened 3 weeks ago

licaon-kter commented 3 weeks ago

...as the submodule used by F-Droid was deemed "unused": https://github.com/yggdrasil-network/yggdrasil-android/commit/ca45b37baa303c9a5a969e6861f7c4d742d45368

maybe we can set it up as a srclib instead, but we don't have a version reference: https://github.com/yggdrasil-network/yggdrasil-android/blob/v0.1-017/.github/workflows/android.yml#L26 since the submodule was providing that

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/aad111d43d8fae946c23fad838f305cb524df965

neilalexander commented 3 weeks ago

This is likely my fault as I didn't know that there were F-Droid builds depending upon that submodule. It can be added back if so.

licaon-kter commented 3 weeks ago

Like I said, we used the submodulex for that, as that's usable for you too, eg. Use it in your CI, and then it's a given that you don't forget to update

We can extract the exact version of it from a file, but devs tend to forget to update those too :))

neilalexander commented 3 weeks ago

Happy to use the submodule for CI too. Right now it just pulls in the latest: https://github.com/yggdrasil-network/yggdrasil-android/blob/6a66960666c718516b89cefffd4d504d3e9ec3f1/.github/workflows/android.yml#L21-L27

... but I'm happy to take the recommendation to use the submodule for both for consistency.