search

yggdrasil-network / yggdrasil-go

An experiment in scalable routing as an encrypted IPv6 overlay network
https://yggdrasil-network.github.io
Other
3.47k stars 236 forks source link

Proper support for WiX 5 #1163

Open Vort opened 1 month ago

Vort commented 1 month ago

build-msi.sh script first installs WiX 5: https://github.com/yggdrasil-network/yggdrasil-go/blob/340cedbe145ec40de2648dab658795ec21e11992/contrib/msi/build-msi.sh#L19 Then executes candle and light: https://github.com/yggdrasil-network/yggdrasil-go/blob/340cedbe145ec40de2648dab658795ec21e11992/contrib/msi/build-msi.sh#L200-L201

The problem is WiX 5 have no candle and light! They were removed in version 4: https://wixtoolset.org/docs/fourthree/

What happens here I suppose is that GitHub Actions contain WiX 3 and it is used despite WiX 5 being installed. I think it is better to port script for correct usage of WiX 5 instead.

neilalexander commented 4 weeks ago

Fancy volunteering a PR?

Vort commented 4 weeks ago

I have almost no knowledge about GitHub Actions and WiX. So to make decent PR I need to learn these technologies. Maybe I will do it, but not now.