Murder Mystery Summary & Rubric Score

[karl-project-review]

Rubric Score

Criteria 1: Valid Python Code

• Score Level: 4/4 (Exceeds Expectations)
• Comment(s): Your code runs without throwing any errors.

  Criteria 2: Implementation of Project Requirements

• Score Level: 4/4 (Exceeds Expectations)
• Comment(s): You implemented all the required functions as well as the TextSample class. Well done!

  Criteria 3: Software Architecture

• Score Level: 4/4 (Exceeds Expectations)
• Comment(s): While the specifications don't require the prepare_text, ngram_creator, and build_frequency_table functions to be within the TextSample class, placing them there was a reasonable choice under the circumstances. Do take note of issue #4, though, as while not using a loop here was not a significant enough problem in this instance for me to deduct points, if we were using a larger sample pool, then a loop would be a more significant improvement over the copy, paste, and modify method.

  Criteria 4: Uses Python Language Features

• Score Level: 4/4 (Exceeds Expectations)
• Comment(s): You consistently use Python language features where appropriate.

  Criteria 5: Produces Accurate Output

• Score Level: 2/4 (Approaches Expectations)
• Comment(s): There are problems with the get_average_sentence_length(), prepare_text(), and frequency_comparison() functions that result in the similarity scores being off. There problems are discussed in more detail in issues #1, #2, and #3.

  Overall Score: 18/20 (Meets Expectations)

  Nice work on this overall! The majority of your code does what it should, and you used Python language features rather than reinventing the wheel. However, I would encourage you to spend some time looking at the frequency_comparison() function to make sure you understand the problems with it discussed in issue #3 and what we could do to fix these issues. Also, as you move forward with your programming, look for places like that in issue #4 where loops or functions could be used to reduce unnecessary redundancy, as this can save you time and make it easier to maintain your code. Again, nice job with this project overall!

[yghern]

I am really dissapointed with my performance, I was hoping for full score. The real lesson for me here is "stop bloody starting graduate project one day before deadline!". But like they said, "better luck next time". Anyway, points noted. Thanks for the review.