ygimenez / Pagination-Utils

A collection of methods to make message pagination with JDA easier.
GNU Lesser General Public License v2.1
27 stars 7 forks source link

Pagination not working in Slash Commands #27

Closed aarondyejr closed 2 years ago

aarondyejr commented 3 years ago

Checklist

Make sure that you've checked all the items below.

Library info

What libraries versions are you using.

Describe the bug

A clear and concise description of what the bug is.

When trying to use the pagination on an embed through slash commands I get 429 errors saying the reaction won't work. I have tried countless times thinking it was my fault and it very well still could be but I have no idea what to change if it is so I am starting to think it is a bug.

To Reproduce

Steps to reproduce the behavior:

  1. Follow the readme
  2. Send the embed via:
    event.hook.sendMessageEmbeds(...).queue { it ->
    Pages.pagination(it, myPages)
    }
  3. Call the slash command
  4. See error

Expected behavior

A clear and concise description of what you expected to happen.

Well I expected it to react to the embed and work as normal.

Screenshots

If applicable, add screenshots to help explain your problem.

image

Additional context

Add any other context about the problem here.

ygimenez commented 3 years ago

Do the reactions appear? That seems like you're getting ratelimited somewhere. Could you try on a private bot please?

aarondyejr commented 3 years ago

@ygimenez They do not appear at all and no matter on what bot I try it on the same thing happens.

avurro commented 3 years ago

Slash commands don't need gateway intents. In fact in the example reported on github the JDA configuration is the following (SlashBotExample):

JDABuilder.createLight(getBottoken(), EnumSet.noneOf(GatewayIntent.class))

If possible try to respect this configuration. (I am also interested in this development)

ygimenez commented 3 years ago

I'm rewriting the library to be compliant with the new features, including buttons and slash commands.

avurro commented 3 years ago

how's the work going ? do you have an alleged release date?

ygimenez commented 3 years ago

I've halted development for a while due to personal issues, but I'll return to it as soon as possible.

sgoudham commented 2 years ago

Has there been anymore work done on this?

ygimenez commented 2 years ago

For sure, you can check the latest commits to see what else was added, I'm just finishing polishing some rough edges before I release a new version.

sgoudham commented 2 years ago

Will the pagination now work through buttons in slash commands since you're not really able to get the message easily?

ygimenez commented 2 years ago

Both types of buttons will be supported, as for slashes all my tests paginate successfully as long as you passed a valid Message object (e.g: the reply message).

sgoudham commented 2 years ago

Ah okay, I was trying earlier to get a message object through slash commands and was unsuccessful. I hope you'll give some examples 😅 Aside from that, is there an ETA on this next release?

ygimenez commented 2 years ago

I don't know, maybe by next month or so

sgoudham commented 2 years ago

Looking forward to it!

ygimenez commented 2 years ago

Please check whether this issue still exists in latest version.

ygimenez commented 2 years ago

Considered fixed. Should it be required feel free to reopen the issue.