ygimenez / Pagination-Utils

A collection of methods to make message pagination with JDA easier.
GNU Lesser General Public License v2.1
27 stars 7 forks source link

Issue with pagination utils on jda 5.0.0 #38

Closed BlitzOffline closed 2 years ago

BlitzOffline commented 2 years ago

Checklist

Make sure that you've checked all the items below.

Library info

What libraries versions are you using.

Describe the bug

There's an error on startup which probably has to do with the major changes JDA v5 is going thru. I was wondering if there is a way to get a development build or anything like that, that works with JDA 5 or are you guys waiting for JDA 5 to get out of alpha before updating it. The error log: https://www.toptal.com/developers/hastebin/uzecoxegiz

To Reproduce

Steps to reproduce the behavior:

  1. Get JDA 5.0.0 alpha.5
  2. Get Pagination-Utils 3.0.6
  3. Use PaginatorBuilder.createPaginator()
ygimenez commented 2 years ago

JDA 5 is still in alpha version, so things are expected to break until they make an official release.

I'll refrain from releasing versions to make it compatible with it due to how volatile alpha phase is (things might change completely without warning). Sorry for the inconvenience, but a fix isn't feasible at the moment.

BlitzOffline commented 2 years ago

Yeah I am aware. I was just hoping that maybe you guys would make an alpha branch or something. I just forked it and made my own tho. I can PR to a different branch than the main if you guys want. I am aware that v5 gets quite a few breaking changes still.

If you guys want me to PR, just let me know with a reply here. will close the issue tho.

ygimenez commented 2 years ago

If your changes stay working after the full release I'll be happy to merge it into master afterwards, thanks for it!