Closed SIMULATAN closed 1 year ago
The work both of you are doing is greatly appreciated, although I'm not sure I'll be able to merge those PRs when the stable version gets released since a lot changed in the nightly branch (mostly optimization and reducing unnecessary edits, but the whole structure as well).
Nonetheless, thanks for adding support to alpha JDA.
I depend on the library for my own discord bot, thus I'd be completely fine with also porting these changes. If you want to, I can make another branch, and try to update yours for alphas, although no guarantee, because I haven't checked out the nightly branch changes yet.
Don't worry about it, I'm just mentioning that it might not be possible to merge the PRs onto master when stable gets released, I'm totally fine with you guys having your own forks.
Due to diverging structures I cannot merge this PR, but I thank you for maintaining this fork while JDA was still in alpha stage.
This PR adds support for JDA 5 (currently .20, will change in the future), based on @BlitzOffline's work in #39 (tysm for that!), but unfortunately, they didn't update their branch as newer JDA alpha versions with breaking changes came out, so we did that ourselves.
We'll most likely continue to update our fork for JDA 5 versions at least until it's stable.
Tasks
Closes #46