[Maintained] Upgrade to JDA 5 (currently: .20)

ygimenez / Pagination-Utils

A collection of methods to make message pagination with JDA easier.

GNU Lesser General Public License v2.1

27 stars 7 forks source link

[Maintained] Upgrade to JDA 5 (currently: .20) #48

Closed SIMULATAN closed 1 year ago

SIMULATAN commented 1 year ago

This PR adds support for JDA 5 (currently .20, will change in the future), based on @BlitzOffline's work in #39 (tysm for that!), but unfortunately, they didn't update their branch as newer JDA alpha versions with breaking changes came out, so we did that ourselves.

We'll most likely continue to update our fork for JDA 5 versions at least until it's stable.

Tasks

[x] bump versions
- [x] 3.1.0 for .13
- [X] 3.2.0 for .16
- [X] 3.3.0 for .20
[X] updated to Java 17 (+ fix for Jitpack)
[ ] implemented review changes (I might've, but I'm not sure, I'll check at some point soon)

Closes #46

ygimenez commented 1 year ago

The work both of you are doing is greatly appreciated, although I'm not sure I'll be able to merge those PRs when the stable version gets released since a lot changed in the nightly branch (mostly optimization and reducing unnecessary edits, but the whole structure as well).

Nonetheless, thanks for adding support to alpha JDA.

SIMULATAN commented 1 year ago

I depend on the library for my own discord bot, thus I'd be completely fine with also porting these changes. If you want to, I can make another branch, and try to update yours for alphas, although no guarantee, because I haven't checked out the nightly branch changes yet.

ygimenez commented 1 year ago

Don't worry about it, I'm just mentioning that it might not be possible to merge the PRs onto master when stable gets released, I'm totally fine with you guys having your own forks.

ygimenez commented 1 year ago

Due to diverging structures I cannot merge this PR, but I thank you for maintaining this fork while JDA was still in alpha stage.