Closed akavel closed 4 years ago
Can you rebase it to fix the tests please?
Whoops, the Smoke Test actually started complaining now :/
@akavel it's your turn to review now ;)
Wow; your changes fly way over my head at this point (though I think I'm starting to understand what "stack bottom" may mean here, sounds great!), and I don't really have time to dig deep on them unfortunately for a big-R Review; but said bluntly, the main thing I'm interested in, is whether this Works For Me™ - and from what I checked, it does indeed seem to do so! 😊 which makes me a happy little hacker, so I'm all LGTM here - huge thanks for your work on this and putting my crude commits straight!!!
Tee hee hee, now, next thing to come will be the actual .dex rendering, I hope, and that one may stretch your patience quite some more ;P not sure when I'll be able to start submitting it however, but we shall see.
THANKS again!
🥳
Fixes to various issues I discovered when trying to use jexport. More details are available in specific commits descriptions.