search

yglukhov / jnim

Nim - Java bridge
MIT License
184 stars 13 forks source link

jexport: allow redefining JnimPackageName with -d #65

Closed akavel closed 4 years ago

akavel commented 4 years ago

This allows running e.g. nim c -d:JnimPackageName=com.akavel.foobar ... to change the Java package name from hardcoded io.github.yglukhov.jnim to something custom.

akavel commented 4 years ago

Ok, I can resend an updated PR, but maybe after #66? The #66 uses this const a lot, so it will be a bit less work for me to fix this PR after some version of #66 is potentially merged, than having to resolve a conflict & rebasing the #66...

akavel commented 4 years ago

Uh, oh, to my surprise, apparently running -d:jnimPackageName actually works equally well already (without changing the variable name in the code)... do you want me to still change the var to start with j, or keep it as is?

yglukhov commented 4 years ago

Ok, it's fine then