search

yglukhov / nimx

GUI library
MIT License
1.09k stars 75 forks source link

Minor compatibility fixes for Nim 0.17.2 #315

Closed windgo-inc closed 6 years ago

windgo-inc commented 6 years ago

I took an interest in nimx as a way to get interactive visualizations working quickly. I am working from the 0.17.2 stable release, and found there were a couple of very minor things which didn't compile. I made a Nim version branch, under the assumption that the use of getFloat on JsonNode in serializers might have been intentional, but it appears the equivalent available from my environment is getFNum. I also do not have a rand function.

jansedlon commented 6 years ago

Someone should accept at least that first commit, because it fixed me error message :)

Tormund commented 6 years ago

Thank you. In general we recommend to use latest Nim from devel branch. We can remove this deprecated calls after 0.17.3 stable Nim released. =)

windgo-inc commented 6 years ago

Great! I am using the development branch now, actually. I ended up making the switch over to the development branch after I finally fixed all the compatibility issues in my own code. Keep up the good work.