allow using sdl2 from homebrew if present

yglukhov / nimx

GUI library

MIT License

1.1k stars 75 forks source link

Closed timotheecour closed 6 years ago

timotheecour commented 6 years ago

fixes error: 'Xcode/SDL/SDL.xcodeproj' does not exist for users that don't want to manually install SDL2 via xcode and instead use homebrew for that (references https://github.com/yglukhov/nimx/issues/320)

it's much simpler to install packages via homebrew on OSX nowdays; this allows using a homebrew installed version of sdl2,

it's not hardcoding brew location to /usr/local/ (not always installed there); it just checks for brew in PATH

timotheecour commented 6 years ago

PTAL, although I couldn't test because of a number of unrelated (new) regression (EDIT: it's https://github.com/yglukhov/nimx/issues/336)

I got this: /Users/timothee/.nimble/pkgs/nimsl-0.3/nimsl/private/glsl_codegen.nim(349, 24) Error: node lacks field: intVal let indexVal = n[1].intVal
then I did: nimble develop nimsl somewhere
```
nimble install
cd test
rm nakefile
nake
```
gives:

SIGSEGV: Illegal storage access. (Attempt to read from nil?)

yglukhov commented 6 years ago

Thank you!