search

yglukhov / nimx

GUI library
MIT License
1.09k stars 75 forks source link

Fix emscripten #452

Open capocasa opened 3 years ago

capocasa commented 3 years ago

This is more to document progress- unsure how to proceed

I started fixing bugs on emscripten when I realized it would probably have worked with an earlier version, but decided to continue anyway

These work with emscripten 2.0.9 and contain backwords incompatible changes. See also https://github.com/yglukhov/jsbind/pull/14

yglukhov commented 3 years ago

Hey @capocasa. What's the status of this? Is it still WIP?

capocasa commented 3 years ago

@yglukhov: It works for latest emscripten but breaks compatibility with older emscripten

You could

(a) accept merge into master, accept dependency change to newer emscripten version, update emscripten version in CI,

(b) accept merge into a new_emscripten dev branch, keep old emscripten version in master