ygojson / ygojson-tools

Tooling for the ygojson project
MIT License
1 stars 0 forks source link

Remove mockwebserver dependency in favor of wiremock #161

Closed magicDGS closed 5 months ago

magicDGS commented 5 months ago

These changes are to simplify the testing of the different client implementation that will be done with #141, as the current custom system does not take into account different ordering of the query-params that might happen with a different implementation.

Using wiremock and its standard structure will be easier to onboard people and also moves forward to remove the dependency on okhttp even for testing.

Also, with these changes we are moving forward on using the capabilities of quarkus to inject dependencies and to enable property-based configuration that on test can be overriden with resources/profiles.

First step for #141

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.508%. Comparing base (abca989) to head (d0569cd).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #161 +/- ## =========================================== Coverage 88.508% 88.508% Complexity 371 371 =========================================== Files 63 63 Lines 992 992 Branches 85 85 =========================================== Hits 878 878 Misses 72 72 Partials 42 42 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.